Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fix QKVParallelLinearWithShardedLora bias bug #10844

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

jeejeelee
Copy link
Collaborator

@jeejeelee jeejeelee commented Dec 3, 2024

Signed-off-by: Jee Jee Li <[email protected]>
@jeejeelee jeejeelee requested a review from khluu December 3, 2024 01:44
Copy link

github-actions bot commented Dec 3, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Dec 3, 2024
@khluu khluu added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 3, 2024
@DarkLight1337 DarkLight1337 merged commit a4cf256 into vllm-project:main Dec 3, 2024
84 of 86 checks passed
@jeejeelee jeejeelee deleted the fix-bias-bug branch December 3, 2024 05:32
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants