Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kernel] Use out in flash_attn_varlen_func #10811

Merged
merged 3 commits into from
Dec 2, 2024
Merged

[Kernel] Use out in flash_attn_varlen_func #10811

merged 3 commits into from
Dec 2, 2024

Conversation

WoosukKwon
Copy link
Collaborator

@WoosukKwon WoosukKwon commented Dec 1, 2024

This PR uses the in-place out argument of flash_attn_varlen_func to avoid redundant copy. This is possible by the change in vllm-project/flash-attention#32

Copy link

github-actions bot commented Dec 1, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Dec 1, 2024
Signed-off-by: Woosuk Kwon <[email protected]>
@WoosukKwon WoosukKwon added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 1, 2024
Signed-off-by: Woosuk Kwon <[email protected]>
@WoosukKwon WoosukKwon merged commit 073a4bd into main Dec 2, 2024
14 of 18 checks passed
@WoosukKwon WoosukKwon deleted the flash-attn-out branch December 2, 2024 01:55
@WoosukKwon
Copy link
Collaborator Author

Just for a note: This PR reduces the small-input latency of opt-125m from 194 ms to 184 ms

Avg latency: 0.18358359679890177 seconds
10% percentile latency: 0.18246181161375716 seconds
25% percentile latency: 0.18272388676996343 seconds
50% percentile latency: 0.18310453748563305 seconds
75% percentile latency: 0.18387063493719324 seconds
90% percentile latency: 0.18499673358164728 seconds
99% percentile latency: 0.18895185411558488 seconds

afeldman-nm pushed a commit to neuralmagic/vllm that referenced this pull request Dec 2, 2024
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants