-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] add xgrammar as guided generation provider #10803
Conversation
Essentially a cleaned up version of this `pr`: vllm-project#10785 Especially since `outlines` is rather slow and the new version is though to intergrate as they do not focus on being pickleable which is a key feature for us using the multiprocessing engine: dottxt-ai/outlines-core#99 I assume more and more will change over to `xgrammar`. This is a minimum implementation. https://arxiv.org/pdf/2411.15100 Signed-off-by: Jannis Schönleber <[email protected]>
Signed-off-by: Jannis Schönleber <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
credits to: vllm-project@865e2a3 Signed-off-by: Jannis Schönleber <[email protected]>
Signed-off-by: Jannis Schönleber <[email protected]>
This pull request has merge conflicts that must be resolved before it can be |
@mgoin All good, perfect :-) I think there is just some more cleanup here. But I close it for now as the support is what I care about :-) |
Essentially a cleaned-up version of this
pr
:#10785
Especially since
outlines
is relatively slow and the new version is toughto integrate as they do not focus on being pickleable, which is a crucial
feature for us using the multiprocessing engine: dottxt-ai/outlines-core#99
I assume more and more will change over to
xgrammar
.This is a minimum implementation.
https://arxiv.org/pdf/2411.15100