Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] add xgrammar as guided generation provider #10803

Closed
wants to merge 4 commits into from

Conversation

joennlae
Copy link
Contributor

@joennlae joennlae commented Dec 1, 2024

Essentially a cleaned-up version of this pr:
#10785

Especially since outlines is relatively slow and the new version is tough
to integrate as they do not focus on being pickleable, which is a crucial
feature for us using the multiprocessing engine: dottxt-ai/outlines-core#99

I assume more and more will change over to xgrammar.

This is a minimum implementation.

https://arxiv.org/pdf/2411.15100

Essentially a cleaned up version of this `pr`:
vllm-project#10785

Especially since `outlines` is rather slow and the new version is though
to intergrate as they do not focus on being pickleable which is a key
feature for us using the multiprocessing engine: dottxt-ai/outlines-core#99

I assume more and more will change over to `xgrammar`.

This is a minimum implementation.

https://arxiv.org/pdf/2411.15100

Signed-off-by: Jannis Schönleber <[email protected]>
Copy link

github-actions bot commented Dec 1, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Dec 1, 2024
Copy link

mergify bot commented Dec 3, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @joennlae.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Dec 3, 2024
@mgoin
Copy link
Member

mgoin commented Dec 3, 2024

Hey @joennlae we landed initial support here #10785. Let me know if something wasn't included that you need. We will be following up with more performance optimizations soon.

@joennlae
Copy link
Contributor Author

joennlae commented Dec 3, 2024

@mgoin All good, perfect :-) I think there is just some more cleanup here. But I close it for now as the support is what I care about :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants