-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Misc] Rename embedding classes to pooling #10801
Conversation
Signed-off-by: DarkLight1337 <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense to me. we should add some docs to explain how embedding models are framed as pooling models. people are familiar with embedding, but not pooling.
Yeah, I'm planning to do that after splitting up the embedding task to more specific ones. |
Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: cedonley <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Part of #10674
VllmModelForEmbedding -> VllmModelForPooling
is_embedding_model -> is_pooling_model
EmbeddingModelRunner -> PoolingModelRunner
EmbeddingOutput -> PoolingOutput
EmbeddingRequestOutput -> PoolingRequestOutput
For API changes, the original name has been deprecated but remains accessible for now.