Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Rename embedding classes to pooling #10801

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Dec 1, 2024

Part of #10674

  • [Internal] VllmModelForEmbedding -> VllmModelForPooling
  • [Internal] is_embedding_model -> is_pooling_model
  • [Internal] EmbeddingModelRunner -> PoolingModelRunner
  • [API] EmbeddingOutput -> PoolingOutput
  • [API] EmbeddingRequestOutput -> PoolingRequestOutput

For API changes, the original name has been deprecated but remains accessible for now.

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 1, 2024
Copy link

github-actions bot commented Dec 1, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the frontend label Dec 1, 2024
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me. we should add some docs to explain how embedding models are framed as pooling models. people are familiar with embedding, but not pooling.

@DarkLight1337
Copy link
Member Author

Yeah, I'm planning to do that after splitting up the embedding task to more specific ones.

@DarkLight1337 DarkLight1337 merged commit d2f058e into vllm-project:main Dec 1, 2024
51 checks passed
@DarkLight1337 DarkLight1337 deleted the pooler-rename branch December 1, 2024 08:29
afeldman-nm pushed a commit to neuralmagic/vllm that referenced this pull request Dec 2, 2024
cedonley pushed a commit to cedonley/vllm that referenced this pull request Dec 7, 2024
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants