Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hardware][CPU] Refactor CPU vector types for ISAs #10787

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ShawnD200
Copy link
Contributor

@ShawnD200 ShawnD200 commented Nov 30, 2024

Abstract three types of vectors: OpsVecType, AttnVecType, and QuantVecType. Also move ISA specifics back to their implementations where they belong, which cleans up the less readable and less maintainable macros in attention and quant.

No functionality change.

@mgoin @bigPYJ1151 @sanketkaleoss @ChipKerchner

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant