[Cleanup][Kernel] Remove if-else with identical branches in marlin 2:4 #10687
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up a useless if-else in
marlin_24_cuda_kernel.cu
:vllm/csrc/quantization/marlin/sparse/marlin_24_cuda_kernel.cu
Lines 299 to 305 in 0a4d968
See the equivalent if-else in
marlin_cuda_kernel.cu
:vllm/csrc/quantization/marlin/dense/marlin_cuda_kernel.cu
Lines 367 to 372 in 80ca1e6
See discussion in #6030
From @alexm-neuralmagic in that issue:
I'd love to leave a better explanation for the discrepancy between the equivalent if statement in
marlin_cuda_kernel.cu
, because this looks very suspicious.(closes #6030)