Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Fix typos in docs #10636

Merged
merged 2 commits into from
Nov 25, 2024
Merged

[Doc] Fix typos in docs #10636

merged 2 commits into from
Nov 25, 2024

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Nov 25, 2024 •
edited
Loading

I missed these in #10621 and #10470

@DarkLight1337
Fix missing code block
3d603b4 
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 25, 2024
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Nov 25, 2024
@DarkLight1337
Actually this is just untested
8086749 
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337 DarkLight1337 changed the title [Doc] Fix missing code block [Doc] Fix typos in docs Nov 25, 2024
@youkaichao youkaichao merged commit 1b583cf into vllm-project:main Nov 25, 2024
33 checks passed
@DarkLight1337 DarkLight1337 deleted the fix-doc-format branch November 26, 2024 02:20
afeldman-nm pushed a commit to neuralmagic/vllm that referenced this pull request Dec 2, 2024
@DarkLight1337 @afeldman-nm
[Doc] Fix typos in docs (vllm-project#10636)
84e74aa 
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Andrew Feldman <[email protected]>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@DarkLight1337
[Doc] Fix typos in docs (vllm-project#10636)
5e7bcc7 
Signed-off-by: DarkLight1337 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russellb russellb russellb left review comments

@youkaichao youkaichao youkaichao approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DarkLight1337 @russellb @youkaichao