Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[torch.compile] force inductor threads #10620

Merged
merged 2 commits into from
Nov 25, 2024
Merged

[torch.compile] force inductor threads #10620

merged 2 commits into from
Nov 25, 2024

Conversation

jeejeelee
Copy link
Collaborator

@jeejeelee jeejeelee commented Nov 25, 2024 •
edited by github-actions bot
Loading

FIX #10619
ping @youkaichao

@jeejeelee
Done
3507cd1 
Signed-off-by: Jee Jee Li <[email protected]>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@jeejeelee
Modify code
4026956 
Signed-off-by: Jee Jee Li <[email protected]>
youkaichao
youkaichao approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job! now the processes are much less.

@youkaichao youkaichao merged commit 7c2134b into vllm-project:main Nov 25, 2024
11 of 14 checks passed
@jeejeelee jeejeelee deleted the force-inductor-threads branch November 25, 2024 07:33
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 28, 2024
@jeejeelee @mfournioux
[torch.compile] force inductor threads (vllm-project#10620)
9fc78e0 
Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: Maxime Fournioux <[email protected]>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@jeejeelee
[torch.compile] force inductor threads (vllm-project#10620)
bce6d5c 
Signed-off-by: Jee Jee Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youkaichao youkaichao youkaichao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Usage]: torch.compile still generates multiple subprocesses
2 participants
@jeejeelee @youkaichao