Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Add dedicated tool calling page to docs #10554

Merged
merged 9 commits into from
Dec 10, 2024
Merged

[Docs] Add dedicated tool calling page to docs #10554

merged 9 commits into from
Dec 10, 2024

Conversation

mgoin
Copy link
Member

@mgoin mgoin commented Nov 21, 2024

Also adds a quickstart example for automatic function calling

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Nov 21, 2024
@simon-mo
Copy link
Collaborator

@K-Mistele to review?

K-Mistele
K-Mistele reviewed Nov 22, 2024
View reviewed changes
docs/source/models/tool_calling.md Outdated Show resolved Hide resolved
docs/source/models/tool_calling.md Outdated Show resolved Hide resolved
docs/source/models/tool_calling.md Outdated Show resolved Hide resolved
@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 2, 2024
@mergify Mergify
Copy link

mergify bot commented Dec 5, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @mgoin.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Dec 5, 2024
@mergify mergify bot removed the needs-rebase label Dec 5, 2024
@mgoin
Move to usage
1c3fb90 
Signed-off-by: mgoin <[email protected]>
@mgoin @tlrmchlsmth
Update tool_calling.md
99732ae 
Co-authored-by: Tyler Michael Smith <[email protected]>
@mgoin mgoin merged commit 6d52528 into vllm-project:main Dec 10, 2024
31 checks passed
@mgoin mgoin deleted the better-tool-calling-docs branch December 10, 2024 01:15
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@mgoin @tlrmchlsmth
[Docs] Add dedicated tool calling page to docs (vllm-project#10554)
e7aa1d3 
Signed-off-by: mgoin <[email protected]>
Co-authored-by: Tyler Michael Smith <[email protected]>
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
@mgoin @tlrmchlsmth @BKitor
[Docs] Add dedicated tool calling page to docs (vllm-project#10554)
1a96690 
Signed-off-by: mgoin <[email protected]>
Co-authored-by: Tyler Michael Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@K-Mistele K-Mistele K-Mistele left review comments

@tlrmchlsmth tlrmchlsmth tlrmchlsmth approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mgoin @simon-mo @tlrmchlsmth @K-Mistele