-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v1] Refactor KVCacheManager for more hash input than token ids #10507
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
c2bfbd5
to
2986dab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great job!
Signed-off-by: rickyx <[email protected]>
Signed-off-by: rickyx <[email protected]>
Signed-off-by: rickyx <[email protected]>
Signed-off-by: rickyx <[email protected]>
Signed-off-by: rickyx <[email protected]>
Signed-off-by: rickyx <[email protected]>
Signed-off-by: rickyx <[email protected]>
Signed-off-by: Cody Yu <[email protected]>
2986dab
to
dcae02e
Compare
…-project#10507) Signed-off-by: rickyx <[email protected]> Signed-off-by: Cody Yu <[email protected]> Co-authored-by: Cody Yu <[email protected]> Signed-off-by: Tyler Michael Smith <[email protected]>
…-project#10507) Signed-off-by: rickyx <[email protected]> Signed-off-by: Cody Yu <[email protected]> Co-authored-by: Cody Yu <[email protected]> Signed-off-by: Maxime Fournioux <[email protected]>
…-project#10507) Signed-off-by: rickyx <[email protected]> Signed-off-by: Cody Yu <[email protected]> Co-authored-by: Cody Yu <[email protected]>
This PR refactors the KVCacheManager such that:
Benchmarking
Running the below on main and the PR shows no diff on performance.