Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci/build] Combine nightly and optional #10465

Merged
merged 1 commit into from
Nov 20, 2024
Merged

[ci/build] Combine nightly and optional #10465

merged 1 commit into from
Nov 20, 2024

Conversation

khluu
Copy link
Collaborator

@khluu khluu commented Nov 19, 2024 •
edited by github-actions bot
Loading

  • Change nightly tests to be optional and remove nightly key
  • Make A100 tests to be optional
  • Remove nightly key
    From now on (after Run optional tests on nightly build buildkite-ci#51 is merged), all scheduled nightly tests will run all optional tests automatically. Other than that, optional tests remain optional to run.

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Nov 19, 2024
youkaichao
youkaichao approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 20, 2024 02:42
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 20, 2024
@simon-mo simon-mo merged commit ed701ca into main Nov 20, 2024
87 of 89 checks passed
@simon-mo simon-mo deleted the khluu/squash_opt_nightly branch November 20, 2024 05:36
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
@khluu
[ci/build] Combine nightly and optional (vllm-project#10465)
8f5691c
tlrmchlsmth pushed a commit to neuralmagic/vllm that referenced this pull request Nov 23, 2024
@khluu @tlrmchlsmth
[ci/build] Combine nightly and optional (vllm-project#10465)
e40cd7f 
Signed-off-by: Tyler Michael Smith <[email protected]>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@khluu
[ci/build] Combine nightly and optional (vllm-project#10465)
4628f18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@youkaichao youkaichao youkaichao approved these changes

@simon-mo simon-mo Awaiting requested review from simon-mo

Assignees
No one assigned
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@khluu @youkaichao @DarkLight1337 @simon-mo