Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] Fix Mamba model initialization and MLP Speculator weights loading #10456

Merged
merged 5 commits into from
Nov 20, 2024
Merged

[Bugfix] Fix Mamba model initialization and MLP Speculator weights loading #10456

merged 5 commits into from
Nov 20, 2024

Conversation

Isotr0py
Copy link
Collaborator

@Isotr0py Isotr0py commented Nov 19, 2024 •
edited by github-actions bot
Loading

FIX #10327 (comment)

Sorry for breaking the test :(

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@Isotr0py
Copy link
Collaborator Author

Isotr0py commented Nov 19, 2024 •
edited
Loading

@DarkLight1337 Seems that the failing Mamba loading is not a bug from weights loading tracker: https://buildkite.com/vllm/ci-aws/builds/11414#019342cb-092d-405f-8d84-89c9f345edd8/182-3271. So I disabled Mamba weights loading tracking temporarily.

I indeed can't find RMS norm in the model checkpoint: https://huggingface.co/tiiuae/falcon-mamba-tiny-dev/tree/main?show_file_info=model.safetensors, perhaps the tested mamba model was not initialized correctly.

@Isotr0py Isotr0py changed the title [Bugfix] Disable Mamba weights loading tracker and fix MLP Speculator loading [Bugfix] Fix Mamba and MLP Speculator weights loading Nov 19, 2024
@Isotr0py Isotr0py changed the title [Bugfix] Fix Mamba and MLP Speculator weights loading [Bugfix] Fix Mamba model initialization and MLP Speculator weights loading Nov 19, 2024
@tlrmchlsmth tlrmchlsmth mentioned this pull request Nov 19, 2024
Merged
@Isotr0py
revert mamba
d6ebd1f 
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py
code format
30f4b2d 
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py Isotr0py added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 20, 2024
@Isotr0py
code format
852f077 
Signed-off-by: Isotr0py <[email protected]>
tlrmchlsmth
tlrmchlsmth approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@tlrmchlsmth tlrmchlsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@tlrmchlsmth tlrmchlsmth enabled auto-merge (squash) November 20, 2024 04:02
@tlrmchlsmth tlrmchlsmth merged commit ad44437 into vllm-project:main Nov 20, 2024
52 checks passed
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
@Isotr0py
[Bugfix] Fix Mamba model initialization and MLP Speculator weights lo…
0e9d8d9 
…ading (vllm-project#10456)

Signed-off-by: Isotr0py <[email protected]>
@Isotr0py Isotr0py deleted the fix-broken-tests branch November 21, 2024 14:29
tlrmchlsmth pushed a commit to neuralmagic/vllm that referenced this pull request Nov 23, 2024
@Isotr0py @tlrmchlsmth
[Bugfix] Fix Mamba model initialization and MLP Speculator weights lo…
b0b74f3 
…ading (vllm-project#10456)

Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Tyler Michael Smith <[email protected]>
@Isotr0py Isotr0py mentioned this pull request Nov 28, 2024
Merged
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@Isotr0py
[Bugfix] Fix Mamba model initialization and MLP Speculator weights lo…
a9219a1 
…ading (vllm-project#10456)

Signed-off-by: Isotr0py <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlrmchlsmth tlrmchlsmth tlrmchlsmth approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Isotr0py @tlrmchlsmth