Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Avoid misleading warning messages #10438

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

jeejeelee
Copy link
Collaborator

@jeejeelee jeejeelee commented Nov 19, 2024

For QWenLMHeadModel and ChatGLMForCausalLM, where multimodal model and LLM share the same model class, incorrect warning messages are output when enabling LoRA for LLM.

BTW, fix QWenLMHeadModel small typo.

ping @DarkLight1337

Signed-off-by: Jee Jee Li <[email protected]>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@DarkLight1337
Copy link
Member

DarkLight1337 commented Nov 19, 2024

I think we can only inherit from SupportsMultiModal in QWenVL (i.e. don't inherit SupportsMultiModal in QWenLLM) to avoid having to modify the existing check logic.

@jeejeelee
Copy link
Collaborator Author

I think we can only inherit from SupportsMultiModal in QWenVL (i.e. don't inherit SupportsMultiModal in QWenLLM) to avoid having to modify the existing check logic.

Sounds great, I will handling it asap

Signed-off-by: Jee Jee Li <[email protected]>
@jeejeelee
Copy link
Collaborator Author

@DarkLight1337 I have handled it, please review it again, thanks

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 19, 2024 05:00
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 19, 2024
@DarkLight1337 DarkLight1337 merged commit 382b6a4 into vllm-project:main Nov 19, 2024
62 checks passed
mikejuliet13 pushed a commit to mikejuliet13/vllm that referenced this pull request Nov 19, 2024
@jeejeelee jeejeelee deleted the fix-lora-warning branch November 19, 2024 14:20
coolkp pushed a commit to coolkp/vllm that referenced this pull request Nov 20, 2024
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 20, 2024
rickyyx pushed a commit to rickyyx/vllm that referenced this pull request Nov 20, 2024
tlrmchlsmth pushed a commit to neuralmagic/vllm that referenced this pull request Nov 23, 2024
Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: Tyler Michael Smith <[email protected]>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants