-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix]Fix Phi-3 BNB online quantization #10417
Conversation
Signed-off-by: Jee Jee Li <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
FYI, I have implemented the TP support for Phi-3 BNB in my branch, it might be useful for addressing the issue you mentioned: https://github.com/Isotr0py/vllm/blob/79f0b5f725ea74f19d8f4a73b9c9df72fb3ac605/vllm/model_executor/model_loader/loader.py#L909-L934 |
thanks,I will look at this asap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for improving the comments as well
Signed-off-by: Jee Jee Li <[email protected]> Signed-off-by: Manjul Mohan <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]> Signed-off-by: Maxime Fournioux <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]> Signed-off-by: rickyx <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]> Signed-off-by: Tyler Michael Smith <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]>
FIX #9937
Work
TODO
For these types of models, there is still a remaining issue regarding TP weight partitioning during online quantization. This will be addressed in the following PR.
ping @mgoin