Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Bump ray to use _overlap_gpu_communication in compiled graph tests #10410

Merged
merged 4 commits into from
Dec 11, 2024

Conversation

ruisearch42
Copy link
Collaborator

@ruisearch42 ruisearch42 commented Nov 18, 2024

No description provided.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@ruisearch42 ruisearch42 changed the title [core] Bump ray to use _overlap_gpu_communication in compiled graph t… [core] Bump ray to use _overlap_gpu_communication in compiled graph tests Nov 25, 2024
@ruisearch42
Copy link
Collaborator Author

/ready

@ruisearch42 ruisearch42 marked this pull request as ready for review November 25, 2024 05:40
@comaniac comaniac added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 25, 2024
@comaniac comaniac enabled auto-merge (squash) November 25, 2024 13:14
Rui Qiao added 3 commits November 25, 2024 17:31
up
Signed-off-by: Rui Qiao <[email protected]>
up
Signed-off-by: Rui Qiao <[email protected]>
auto-merge was automatically disabled November 25, 2024 17:33

Head branch was pushed to by a user without write access

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 3, 2024 07:31
@DarkLight1337
Copy link
Member

PTAL at the test failure.

Signed-off-by: Rui Qiao <[email protected]>
@mergify mergify bot added the ci/build label Dec 11, 2024
@comaniac comaniac merged commit 72ff3a9 into vllm-project:main Dec 11, 2024
73 checks passed
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Dec 12, 2024
…ests (vllm-project#10410)

Signed-off-by: Rui Qiao <[email protected]>
Signed-off-by: Rui Qiao <[email protected]>
Co-authored-by: Rui Qiao <[email protected]>
Signed-off-by: Akshat Tripathi <[email protected]>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants