[bugfix] Fix static asymmetric quantization case #10334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `scaled_int8_quant` was used with asymmetric static input quantization, the zero point was used to quantize the input, but not returned from the function. As a result, the zero point was not passed to scaled matmul, resulting in erroneous output (gibberish when generating). Signed-off-by: Daniël de Kok <[email protected]>
Signed-off-by: luka <[email protected]>
ProExpertProg
requested review from
tlrmchlsmth and
WoosukKwon
as code owners
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
|
@danieldk could you please take a look and verify this fix works for you? It seems to be working on my end. |
tlrmchlsmth
approved these changes
Nov 14, 2024
tlrmchlsmth
reviewed
Nov 14, 2024
Signed-off-by: luka <[email protected]>
ProExpertProg
requested review from
mgoin and
robertgshaw2-neuralmagic
as code owners
mgoin
approved these changes
Nov 14, 2024
KuntaiDu
pushed a commit
to KuntaiDu/vllm
that referenced
this pull request
Nov 20, 2024
Signed-off-by: Daniël de Kok <[email protected]> Signed-off-by: luka <[email protected]> Co-authored-by: Daniël de Kok <[email protected]>
mfournioux
pushed a commit
to mfournioux/vllm
that referenced
this pull request
Nov 20, 2024
Signed-off-by: Daniël de Kok <[email protected]> Signed-off-by: luka <[email protected]> Co-authored-by: Daniël de Kok <[email protected]> Signed-off-by: Maxime Fournioux <[email protected]>
rickyyx
pushed a commit
to rickyyx/vllm
that referenced
this pull request
Nov 20, 2024
Signed-off-by: Daniël de Kok <[email protected]> Signed-off-by: luka <[email protected]> Co-authored-by: Daniël de Kok <[email protected]> Signed-off-by: rickyx <[email protected]>
tlrmchlsmth
pushed a commit
to neuralmagic/vllm
that referenced
this pull request
Nov 23, 2024
Signed-off-by: Daniël de Kok <[email protected]> Signed-off-by: luka <[email protected]> Co-authored-by: Daniël de Kok <[email protected]> Signed-off-by: Tyler Michael Smith <[email protected]>
sleepwalker2017
pushed a commit
to sleepwalker2017/vllm
that referenced
this pull request
Dec 13, 2024
Signed-off-by: Daniël de Kok <[email protected]> Signed-off-by: luka <[email protected]> Co-authored-by: Daniël de Kok <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a complete fix for #10292. In the static quantization case, the AZP needs to be folded into
azp_adjahead of time.FIX #10292