Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Model][LoRA]LoRA support added for idefics3 #10281

Merged
merged 6 commits into from
Nov 13, 2024
Merged

[Model][LoRA]LoRA support added for idefics3 #10281

merged 6 commits into from
Nov 13, 2024

Conversation

B-201
Copy link
Contributor

@B-201 B-201 commented Nov 13, 2024 •
edited
Loading

  1. LoRA supported for inference in idefics3.
  2. BTW, this also fixes a bug introduced in [Model] Add Idefics3 support #9767, which caused the length of dummy_data to exceed the maximum model length setting.
  3. Removed some unused code.

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Nov 13, 2024
@B-201 B-201 marked this pull request as ready for review November 13, 2024 05:59
DarkLight1337
DarkLight1337 approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I assume you have already tested this on your own?

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 13, 2024
jeejeelee
jeejeelee approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@jeejeelee jeejeelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm, @DarkLight1337 could you please look at this PR, thanks~

@DarkLight1337 DarkLight1337 mentioned this pull request Nov 13, 2024
Open
77 tasks
@B-201
Copy link
Contributor Author

B-201 commented Nov 13, 2024

Looks good, I assume you have already tested this on your own?

Yes, I trained a LoRA myself and tested it locally. It runs very well, and the results align with those on transformers.

@DarkLight1337 DarkLight1337 merged commit d909acf into vllm-project:main Nov 13, 2024
62 checks passed
rickyyx pushed a commit to rickyyx/vllm that referenced this pull request Nov 13, 2024
@B-201 @rickyyx
[Model][LoRA]LoRA support added for idefics3 (vllm-project#10281)
266629b 
Signed-off-by: B-201 <[email protected]>
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
@B-201 @sumitd2
[Model][LoRA]LoRA support added for idefics3 (vllm-project#10281)
b0588ab 
Signed-off-by: B-201 <[email protected]>
Signed-off-by: Sumit Dubey <[email protected]>
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
@B-201
[Model][LoRA]LoRA support added for idefics3 (vllm-project#10281)
cbd2f1d 
Signed-off-by: B-201 <[email protected]>
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 20, 2024
@B-201 @mfournioux
[Model][LoRA]LoRA support added for idefics3 (vllm-project#10281)
b1555d2 
Signed-off-by: B-201 <[email protected]>
Signed-off-by: Maxime Fournioux <[email protected]>
tlrmchlsmth pushed a commit to neuralmagic/vllm that referenced this pull request Nov 23, 2024
@B-201 @tlrmchlsmth
[Model][LoRA]LoRA support added for idefics3 (vllm-project#10281)
d3b10cf 
Signed-off-by: B-201 <[email protected]>
Signed-off-by: Tyler Michael Smith <[email protected]>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@B-201
[Model][LoRA]LoRA support added for idefics3 (vllm-project#10281)
473695f 
Signed-off-by: B-201 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@jeejeelee jeejeelee jeejeelee approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@B-201 @jeejeelee @DarkLight1337