Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI/Build] Fix VLM broadcast test tp_size passing #10160

Closed
wants to merge 36 commits into from
Closed

[CI/Build] Fix VLM broadcast test tp_size passing #10160

wants to merge 36 commits into from
+2 −0

Conversation

Isotr0py
Copy link
Collaborator

@Isotr0py Isotr0py commented Nov 8, 2024 •
edited by github-actions bot
Loading

  • Fix tensor_parallel_size not passed in VLM broadcast test.

Isotr0py and others added 28 commits November 9, 2024 00:27
@Isotr0py
fix missing tp_size
2c69981 
Signed-off-by: Isotr0py <[email protected]>
@rafvasq @Isotr0py
Doc: Improve benchmark documentation (vllm-project#9927)
719a17d 
Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
@hanzhi713 @Isotr0py
[Core][Distributed] Refactor ipc buffer init in CustomAllreduce (vllm…
8e05113 
…-project#10030)

Signed-off-by: Hanzhi Zhou <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
@russellb @Isotr0py
[CI/Build] Improve mypy + python version matrix (vllm-project#10041)
ba43302 
Signed-off-by: Russell Bryant <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
@flaviabeo @maxdebayser @Isotr0py
Adds method to read the pooling types from model's files (vllm-projec…
e253590 
…t#9506)

Signed-off-by: Flavia Beo <[email protected]>
Signed-off-by: Max de Bayser <[email protected]>
Co-authored-by: Max de Bayser <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
@DIYer22 @Isotr0py
[Frontend] Fix multiple values for keyword argument error (vllm-proje…
cc22826 
…ct#10075) (vllm-project#10076)

Signed-off-by: Lei <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
@bigPYJ1151 @Isotr0py
[Hardware][CPU][bugfix] Fix half dtype support on AVX2-only target (v…
b6b3fc3 
…llm-project#10108)

Signed-off-by: jiang1.li <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
@li-plus @Isotr0py
[Bugfix] Make image processor respect mm_processor_kwargs for Qwen2…
96568d7 
…-VL (vllm-project#10112)

Signed-off-by: Jiahao Li <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
@spliii @ywang96 @Isotr0py
[Misc] Add Gamma-Distribution Request Generation Support for Serving …
15f9431 
…Benchmark. (vllm-project#10105)

Signed-off-by: Mozhou <[email protected]>
Co-authored-by: Roger Wang <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
@maxdebayser @Isotr0py
[Frontend] Tool calling parser for Granite 3.0 models (vllm-project#9027
e9273e1 
)

Signed-off-by: Max de Bayser <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
@NickLucche @Isotr0py
[Feature] [Spec decode]: Combine chunked prefill with speculative dec…
55bda6f 
…oding (vllm-project#9291)

Signed-off-by: NickLucche <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
@russellb @Isotr0py
[CI/Build] Always run mypy (vllm-project#10122)
98ac0ed 
Signed-off-by: Russell Bryant <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
@russellb @Isotr0py
[CI/Build] Add shell script linting using shellcheck (vllm-project#7925)
72fe6ba 
Signed-off-by: Russell Bryant <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
@russellb @Isotr0py
[CI/Build] Automate PR body text cleanup (vllm-project#10082)
daa0814 
Signed-off-by: Russell Bryant <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
@dependabot @Isotr0py
Bump actions/setup-python from 5.2.0 to 5.3.0 (vllm-project#9745)
e30bfcd 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Isotr0py <[email protected]>
@litianjian @DarkLight1337 @Isotr0py
Online video support for VLMs (vllm-project#10020)
d6ad92b 
Signed-off-by: DarkLight1337 <[email protected]>
Co-authored-by: litianjian <[email protected]>
Co-authored-by: DarkLight1337 <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
@dependabot @Isotr0py
Bump actions/checkout from 4.2.1 to 4.2.2 (vllm-project#9746)
9047e65 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Isotr0py <[email protected]>
@ycool @Isotr0py
[Misc] report relevant env vars in collect_env.py tool (vllm-project#…
27fed1f 
…9293)

Signed-off-by: Isotr0py <[email protected]>
@WoosukKwon @Isotr0py
[V1] Add all_token_ids attribute to Request (vllm-project#10135)
7e24806 
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
@comaniac @Isotr0py
[V1] Prefix caching (take 2) (vllm-project#9972)
5a78aa6 
Signed-off-by: Cody Yu <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
@russellb @Isotr0py
[CI/Build] Give PR cleanup job PR write access (vllm-project#10139)
c783237 
Signed-off-by: Russell Bryant <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
@whyiug @Isotr0py
[Doc] Update FAQ links in spec_decode.rst (vllm-project#9662)
4775ad0 
Signed-off-by: whyiug <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
@DearPlanet @Isotr0py
[Bugfix] Add error handling when server cannot respond any valid toke…
7b5ba6f 
…ns (vllm-project#5895)

Signed-off-by: Isotr0py <[email protected]>
@MengqingCao @Isotr0py
[Misc] Fix ImportError causing by triton (vllm-project#9493)
077e174 
Signed-off-by: Isotr0py <[email protected]>
@russellb @Isotr0py
[Doc] Move CONTRIBUTING to docs site (vllm-project#9924)
8c16473 
Signed-off-by: Russell Bryant <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
@sighingnow @Isotr0py
Fixes a typo about 'max_decode_seq_len' which causes crashes with cud…
57dbe9a 
…a graph. (vllm-project#9285)

Signed-off-by: Tao He <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
@mgoin @Isotr0py
Add hf_transfer to testing image (vllm-project#10096)
59fde34 
Signed-off-by: Isotr0py <[email protected]>
@DarkLight1337 @Isotr0py
[Misc] Fix typo in vllm-project#5895 (vllm-project#10145)
3af4b71 
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
yma11 and others added 7 commits November 9, 2024 00:27
@yma11 @Isotr0py
[Bugfix][XPU] Fix xpu tp by introducing XpuCommunicator (vllm-project…
c9abd93 
…#10144)

Signed-off-by: yan ma <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py
[Model] Expose size to Idefics3 as mm_processor_kwargs (vllm-project#…
b9b50b5 
…10146)

Signed-off-by: Isotr0py <[email protected]>
@ywang96 @Isotr0py
[V1]Enable APC by default only for text models (vllm-project#10148)
67a6c22 
Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
@DarkLight1337 @Isotr0py
[CI/Build] Update CPU tests to include all "standard" tests (vllm-pro…
167b9f7 
…ject#5481)

Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
@patrickvonplaten @Isotr0py
Fix edge case Mistral tokenizer (vllm-project#10152)
70d20ca 
Signed-off-by: Isotr0py <[email protected]>
@sroy745 @Isotr0py
Disable spec-decode + chunked-prefill for draft models with tensor pa…
2318a0f 
…rallelism > 1 (vllm-project#10136)

Signed-off-by: Sourashis Roy <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py
fix multi-gpus on hf_runner
ca29e63 
Signed-off-by: Isotr0py <[email protected]>
@mergify mergify bot added documentation Improvements or additions to documentation ci/build frontend labels Nov 8, 2024
@Isotr0py
Copy link
Collaborator Author

Isotr0py commented Nov 8, 2024

Ooops, I forgot signed off...

@Isotr0py Isotr0py closed this Nov 8, 2024
@Isotr0py Isotr0py reopened this Nov 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@Isotr0py Isotr0py closed this Nov 8, 2024
@Isotr0py Isotr0py deleted the ci-broadcast branch November 8, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 Awaiting requested review from DarkLight1337 DarkLight1337 is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@mgoin mgoin Awaiting requested review from mgoin

@youkaichao youkaichao Awaiting requested review from youkaichao

@simon-mo simon-mo Awaiting requested review from simon-mo

@njhill njhill Awaiting requested review from njhill

@LiuXiaoxuanPKU LiuXiaoxuanPKU Awaiting requested review from LiuXiaoxuanPKU

@robertgshaw2-neuralmagic robertgshaw2-neuralmagic Awaiting requested review from robertgshaw2-neuralmagic

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon

@zhuohan123 zhuohan123 Awaiting requested review from zhuohan123

@alexm-neuralmagic alexm-neuralmagic Awaiting requested review from alexm-neuralmagic

@comaniac comaniac Awaiting requested review from comaniac

Assignees
No one assigned
Labels
ci/build documentation Improvements or additions to documentation frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.