Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix edge case Mistral tokenizer #10152

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Fix edge case Mistral tokenizer #10152

merged 1 commit into from
Nov 8, 2024

Conversation

patrickvonplaten
Copy link
Contributor

@patrickvonplaten patrickvonplaten commented Nov 8, 2024 •
edited
Loading

Fixes: #9907

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@patrickvonplaten patrickvonplaten mentioned this pull request Nov 8, 2024
Closed
1 task
DarkLight1337
DarkLight1337 reviewed Nov 8, 2024
View reviewed changes
vllm/transformers_utils/tokenizers/mistral.py
# Make sure special tokens will not raise
tokenizer_.special_token_policy = SpecialTokenPolicy.IGNORE

elif isinstance(tokenizer_, SentencePieceTokenizer):
elif self.is_spm:
Copy link
Member

@DarkLight1337 DarkLight1337 Nov 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it just me or do I not see where self.is_spm is being used here? Is L282 the only real change in this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the rest is just to reduce LOC a bit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/vllm-project/vllm/pull/10152/files#r1834507703

patrickvonplaten
patrickvonplaten commented Nov 8, 2024
View reviewed changes
vllm/transformers_utils/tokenizers/mistral.py
assert isinstance(self.tokenizer,
(Tekkenizer, SentencePieceTokenizer)), type(
self.tokenizer)
assert self.is_tekken or self.is_spm, type(self.tokenizer)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reduce LOC

patrickvonplaten
patrickvonplaten commented Nov 8, 2024
View reviewed changes
vllm/transformers_utils/tokenizers/mistral.py
assert isinstance(self.tokenizer,
(Tekkenizer, SentencePieceTokenizer)), type(
self.tokenizer)
assert self.is_tekken or self.is_spm, type(self.tokenizer)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reduce LOC

DarkLight1337
DarkLight1337 approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, as long as mypy still passes.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 8, 2024 14:39
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 8, 2024
@DarkLight1337 DarkLight1337 merged commit 0535e5f into vllm-project:main Nov 8, 2024
62 checks passed
Isotr0py pushed a commit to Isotr0py/vllm that referenced this pull request Nov 8, 2024
@patrickvonplaten @Isotr0py
Fix edge case Mistral tokenizer (vllm-project#10152)
70d20ca 
Signed-off-by: Isotr0py <[email protected]>
omer-dayan pushed a commit to omer-dayan/vllm that referenced this pull request Nov 10, 2024
@patrickvonplaten @omer-dayan
Fix edge case Mistral tokenizer (vllm-project#10152)
ca8f26c 
Signed-off-by: OmerD <[email protected]>
JC1DA pushed a commit to JC1DA/vllm that referenced this pull request Nov 11, 2024
@patrickvonplaten @JC1DA
Fix edge case Mistral tokenizer (vllm-project#10152)
f29198a 
Signed-off-by: Loc Huynh <[email protected]>
jeejeelee pushed a commit to jeejeelee/vllm that referenced this pull request Nov 11, 2024
@patrickvonplaten @jeejeelee
Fix edge case Mistral tokenizer (vllm-project#10152)
2320543 
Signed-off-by: Jee Jee Li <[email protected]>
rickyyx pushed a commit to rickyyx/vllm that referenced this pull request Nov 13, 2024
@patrickvonplaten @rickyyx
Fix edge case Mistral tokenizer (vllm-project#10152)
d6742bc
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
@patrickvonplaten @sumitd2
Fix edge case Mistral tokenizer (vllm-project#10152)
cab83d0 
Signed-off-by: Sumit Dubey <[email protected]>
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
@patrickvonplaten
Fix edge case Mistral tokenizer (vllm-project#10152)
08186d6
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 20, 2024
@patrickvonplaten @mfournioux
Fix edge case Mistral tokenizer (vllm-project#10152)
502a127 
Signed-off-by: Maxime Fournioux <[email protected]>
tlrmchlsmth pushed a commit to neuralmagic/vllm that referenced this pull request Nov 23, 2024
@patrickvonplaten @tlrmchlsmth
Fix edge case Mistral tokenizer (vllm-project#10152)
d63b2ab 
Signed-off-by: Tyler Michael Smith <[email protected]>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@patrickvonplaten
Fix edge case Mistral tokenizer (vllm-project#10152)
dbf27cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Mistral 'SentencePieceTokenizer' object has no attribute 'id_to_byte_piece'
2 participants
@patrickvonplaten @DarkLight1337