-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Model] Expose size to Idefics3 as mm_processor_kwargs #10146
[Model] Expose size to Idefics3 as mm_processor_kwargs #10146
Conversation
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
This is unrelated to this PR, but I feel the test script names in this directory are a bit unreasonable. |
Perhaps we can consolidate the |
Let's do that in a separate PR. |
Good idea. Perhaps https://github.com/vllm-project/vllm/tree/main/tests/multimodal is a better choice |
…10146) Signed-off-by: Isotr0py <[email protected]>
…10146) Signed-off-by: Isotr0py <[email protected]> Signed-off-by: Loc Huynh <[email protected]>
…10146) Signed-off-by: Isotr0py <[email protected]> Signed-off-by: Jee Jee Li <[email protected]>
…10146) Signed-off-by: Isotr0py <[email protected]>
…10146) Signed-off-by: Isotr0py <[email protected]> Signed-off-by: Sumit Dubey <[email protected]>
…10146) Signed-off-by: Isotr0py <[email protected]>
…10146) Signed-off-by: Isotr0py <[email protected]> Signed-off-by: Maxime Fournioux <[email protected]>
…10146) Signed-off-by: Isotr0py <[email protected]> Signed-off-by: Tyler Michael Smith <[email protected]>
…10146) Signed-off-by: Isotr0py <[email protected]>
size
to initializeIdefics3Processor
/Idefics3ImageProcessor
, which can be used to reduce resized image size and save memory: https://huggingface.co/HuggingFaceM4/Idefics3-8B-Llama3#model-optimizationscc @jeejeelee @B-201