Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model] Expose size to Idefics3 as mm_processor_kwargs #10146

Merged
merged 11 commits into from
Nov 8, 2024

Conversation

Isotr0py
Copy link
Collaborator

@Isotr0py Isotr0py commented Nov 8, 2024

cc @jeejeelee @B-201

Copy link

github-actions bot commented Nov 8, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
@jeejeelee
Copy link
Collaborator

This is unrelated to this PR, but I feel the test script names in this directory are a bit unreasonable.

@Isotr0py
Copy link
Collaborator Author

Isotr0py commented Nov 8, 2024

Perhaps we can consolidate the mm_processor_kwargs tests as well?

@DarkLight1337
Copy link
Member

Let's do that in a separate PR.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 8, 2024 08:31
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 8, 2024
@jeejeelee
Copy link
Collaborator

Perhaps we can consolidate the mm_processor_kwargs tests as well?

Good idea. Perhaps https://github.com/vllm-project/vllm/tree/main/tests/multimodal is a better choice

@DarkLight1337 DarkLight1337 merged commit 1ff4aed into vllm-project:main Nov 8, 2024
54 of 63 checks passed
@Isotr0py Isotr0py deleted the idefics3-longest-edge branch November 8, 2024 15:38
Isotr0py added a commit to Isotr0py/vllm that referenced this pull request Nov 8, 2024
JC1DA pushed a commit to JC1DA/vllm that referenced this pull request Nov 11, 2024
jeejeelee pushed a commit to jeejeelee/vllm that referenced this pull request Nov 11, 2024
rickyyx pushed a commit to rickyyx/vllm that referenced this pull request Nov 13, 2024
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 20, 2024
tlrmchlsmth pushed a commit to neuralmagic/vllm that referenced this pull request Nov 23, 2024
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants