Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5/n][pipeline-gen] Method to read test steps from Yaml file #44

Merged
merged 6 commits into from
Oct 9, 2024

Conversation

khluu
Copy link
Collaborator

@khluu khluu commented Oct 9, 2024

No description provided.

p
Signed-off-by: kevin <[email protected]>
@khluu khluu requested a review from aslonnie October 9, 2024 21:35
khluu added 2 commits October 9, 2024 21:35
p
Signed-off-by: kevin <[email protected]>
p
Signed-off-by: kevin <[email protected]>

@click.command()
@click.option("--test_path", type=str, required=True, help="Path to the test pipeline yaml file")
@click.option("--run_all", type=str)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add help string that says "1" means true? and all other values means false?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@click.command()
@click.option("--test_path", type=str, required=True, help="Path to the test pipeline yaml file")
@click.option("--run_all", type=str)
@click.option("--list_file_diff", type=str)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a file or a diff? could you add a help for this too?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

khluu added 3 commits October 9, 2024 22:26
p
Signed-off-by: kevin <[email protected]>
p
Signed-off-by: kevin <[email protected]>
p
Signed-off-by: kevin <[email protected]>
@khluu khluu merged commit 1de5202 into main Oct 9, 2024
1 check passed
@khluu khluu deleted the khluu/pipeline_gen_read branch October 29, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants