-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds the Intrepid and it's Corresponding Files. #256
Draft
Doctor-Derp
wants to merge
214
commits into
vlggms:dev
Choose a base branch
from
Doctor-Derp:SEV-Intrepid!
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+275,645
−3,051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doctor-Derp
changed the title
Ports Intrepid and it's Corresponding Files.
Adds Intrepid and it's Corresponding Files.
Jan 2, 2022
Doctor-Derp
changed the title
Adds Intrepid and it's Corresponding Files.
Adds the Intrepid and it's Corresponding Files.
Jan 2, 2022
EgorDinamit
added
Red Label
High importance issue/pull request.
🍁1 Map
Anything mapping-related.
📘1 Feature
Something new being added.
labels
Jan 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is currently failing on the following, for reference:
Map key 'intrepid' is present in the repository, but is not listed in .github/workflows/test.yml!
test: running(fail) "maps contain no step_[xy]"
test: running(fail) "maps contain no layer adjustments"
maps/intrepid/intrepid1.dmm:"Ri" = (/obj/item/storage/mirror{pixel_y = 29},/obj/structure/hygiene/sink{layer = 3; pixel_y = 23},/turf/simulated/floor/tiled/dark/monotile,/area/space)
124 to_world uses (expecting exactly 117)
## ERROR: Cannot read null.x - sound_player.dm - 229
## ERROR: proc name: PrivUpdateListenerLoc (/datum/sound_token/proc/PrivUpdateListenerLoc)
## ERROR: Cannot read null.x - sound_player.dm - 229
## ERROR: proc name: PrivUpdateListenerLoc (/datum/sound_token/proc/PrivUpdateListenerLoc)
## ERROR: Cannot read null.x - sound_player.dm - 229
## ERROR: proc name: PrivUpdateListenerLoc (/datum/sound_token/proc/PrivUpdateListenerLoc)
Will be helping out with this PR's code part. |
EgorDinamit
force-pushed
the
SEV-Intrepid!
branch
from
March 19, 2022 09:50
b910967
to
faf42d7
Compare
EgorDinamit
force-pushed
the
SEV-Intrepid!
branch
from
May 14, 2022 17:22
6a32a92
to
9730ee9
Compare
EgorDinamit
force-pushed
the
SEV-Intrepid!
branch
2 times, most recently
from
May 27, 2022 18:44
74a3113
to
c141d91
Compare
EgorDinamit
force-pushed
the
SEV-Intrepid!
branch
4 times, most recently
from
December 10, 2022 12:57
29db44a
to
2fc8758
Compare
EgorDinamit
force-pushed
the
SEV-Intrepid!
branch
from
December 15, 2022 11:10
e5afdb1
to
2fc8758
Compare
EgorDinamit
force-pushed
the
SEV-Intrepid!
branch
from
January 8, 2023 12:22
c761544
to
76a816c
Compare
EgorDinamit
force-pushed
the
SEV-Intrepid!
branch
from
February 12, 2023 15:23
e329e0e
to
47b1c3b
Compare
EgorDinamit
added
the
💿3 Test Merge Candidate
Should be test merged to test its functionality.
label
Feb 19, 2023
EgorDinamit
force-pushed
the
SEV-Intrepid!
branch
2 times, most recently
from
February 24, 2023 15:48
e594f37
to
df0c245
Compare
EgorDinamit
force-pushed
the
SEV-Intrepid!
branch
from
March 9, 2023 20:11
ecd14f9
to
c7e85f5
Compare
EgorDinamit
force-pushed
the
SEV-Intrepid!
branch
from
April 5, 2023 06:57
c7e85f5
to
b3c3f95
Compare
EgorDinamit
force-pushed
the
SEV-Intrepid!
branch
from
April 21, 2023 14:12
b3c3f95
to
78ce479
Compare
EgorDinamit
force-pushed
the
SEV-Intrepid!
branch
2 times, most recently
from
April 30, 2023 13:06
bfee544
to
3273506
Compare
EgorDinamit
force-pushed
the
SEV-Intrepid!
branch
2 times, most recently
from
May 12, 2023 13:43
a642414
to
417f27c
Compare
EgorDinamit
force-pushed
the
SEV-Intrepid!
branch
from
May 17, 2023 11:08
d853315
to
96feb21
Compare
…or, other stuff. CO gets a heavy revolver, XO gets holdout revolver, Senator gets normal military revolver. Autolathe now has missing ammo magazines. Senator's door now has unique-ish design.
EgorDinamit
force-pushed
the
SEV-Intrepid!
branch
from
February 23, 2024 13:40
3931750
to
80418c0
Compare
This adds marine veteran role, the first trusted locked role
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Red Label
High importance issue/pull request.
📘1 Feature
Something new being added.
🍁1 Map
Anything mapping-related.
💿3 Test Merge Candidate
Should be test merged to test its functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Pull Request
Adds a lowpop ship the TGLV Intrepid! (And it's relevant files.)
Thank you to the original Torch mappers, and baystation devs for giving me a template to work off of, as well as some examples to help me along the way!
(Bottom Deck. W.I.P.)
(Top Deck. W.I.P.)
Why It's Good For The Game
New ship! A lowpop one too, so 1 or 2 people don't have to deal with the 6-deck Torch all the time. Also variety is nice.
If people want the Torch badly, or if we have enough population, we can switch. I didn't expect this to be a full Torch replacement.
Did you test it?
Yes- I'm testing it as we go along. It's still a work in progress.
Changelog
🆑
rscadd: Adds a new map!
maptweak: Adds a new map!
/:cl: