Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the Intrepid and it's Corresponding Files. #256

Draft
wants to merge 214 commits into
base: dev
Choose a base branch
from

Conversation

Doctor-Derp
Copy link
Contributor

@Doctor-Derp Doctor-Derp commented Jan 2, 2022

About the Pull Request

Adds a lowpop ship the TGLV Intrepid! (And it's relevant files.)

Thank you to the original Torch mappers, and baystation devs for giving me a template to work off of, as well as some examples to help me along the way!

(Bottom Deck. W.I.P.)
intrepid1-1-small

(Top Deck. W.I.P.)
intrepid2-1-small

Why It's Good For The Game

New ship! A lowpop one too, so 1 or 2 people don't have to deal with the 6-deck Torch all the time. Also variety is nice.

If people want the Torch badly, or if we have enough population, we can switch. I didn't expect this to be a full Torch replacement.

Did you test it?

Yes- I'm testing it as we go along. It's still a work in progress.

Changelog

🆑
rscadd: Adds a new map!
maptweak: Adds a new map!
/:cl:

@Doctor-Derp Doctor-Derp changed the title Ports Intrepid and it's Corresponding Files. Adds Intrepid and it's Corresponding Files. Jan 2, 2022
@Doctor-Derp Doctor-Derp changed the title Adds Intrepid and it's Corresponding Files. Adds the Intrepid and it's Corresponding Files. Jan 2, 2022
@EgorDinamit EgorDinamit added Red Label High importance issue/pull request. 🍁1 Map Anything mapping-related. 📘1 Feature Something new being added. labels Jan 2, 2022
Copy link
Collaborator

@Shadowtail117 Shadowtail117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is currently failing on the following, for reference:
Map key 'intrepid' is present in the repository, but is not listed in .github/workflows/test.yml!

	test: running(fail) "maps contain no step_[xy]"
	test: running(fail) "maps contain no layer adjustments"
maps/intrepid/intrepid1.dmm:"Ri" = (/obj/item/storage/mirror{pixel_y = 29},/obj/structure/hygiene/sink{layer = 3; pixel_y = 23},/turf/simulated/floor/tiled/dark/monotile,/area/space)

124 to_world uses (expecting exactly 117)

## ERROR: Cannot read null.x - sound_player.dm - 229
## ERROR: proc name: PrivUpdateListenerLoc (/datum/sound_token/proc/PrivUpdateListenerLoc)
## ERROR: Cannot read null.x - sound_player.dm - 229
## ERROR: proc name: PrivUpdateListenerLoc (/datum/sound_token/proc/PrivUpdateListenerLoc)
## ERROR: Cannot read null.x - sound_player.dm - 229
## ERROR: proc name: PrivUpdateListenerLoc (/datum/sound_token/proc/PrivUpdateListenerLoc)

@EgorDinamit EgorDinamit self-assigned this Jan 3, 2022
@EgorDinamit
Copy link
Member

Will be helping out with this PR's code part.

@EgorDinamit EgorDinamit force-pushed the SEV-Intrepid! branch 2 times, most recently from 74a3113 to c141d91 Compare May 27, 2022 18:44
@EgorDinamit EgorDinamit force-pushed the SEV-Intrepid! branch 4 times, most recently from 29db44a to 2fc8758 Compare December 10, 2022 12:57
@EgorDinamit EgorDinamit added the 💿3 Test Merge Candidate Should be test merged to test its functionality. label Feb 19, 2023
@EgorDinamit EgorDinamit force-pushed the SEV-Intrepid! branch 2 times, most recently from e594f37 to df0c245 Compare February 24, 2023 15:48
@EgorDinamit EgorDinamit force-pushed the SEV-Intrepid! branch 2 times, most recently from bfee544 to 3273506 Compare April 30, 2023 13:06
@EgorDinamit EgorDinamit force-pushed the SEV-Intrepid! branch 2 times, most recently from a642414 to 417f27c Compare May 12, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Red Label High importance issue/pull request. 📘1 Feature Something new being added. 🍁1 Map Anything mapping-related. 💿3 Test Merge Candidate Should be test merged to test its functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants