Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nanoui stuff 2: Electric boogalo #184

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Nanoui stuff 2: Electric boogalo #184

wants to merge 2 commits into from

Conversation

EgorDinamit
Copy link
Member

About the Pull Request

Ports VOREStation/VOREStation/pull/8224
Ports VOREStation/VOREStation/pull/8292

Nanoui scripts modified to load templates in parallel instead of one at a time.
Nanoui scripts modified to be willing to load from the resource bundle if available, falling back to Ajax-loading the individual templates if absent.
Deletes some broken unused code in /datum/asset/nanoui/send()
This reduces the number of assets needing to be sent to every client on join by 150ish, reducing load on the server and flickering mouse after connecting.
The javascript changes are fully backwards compatible, if the server-side changes are reversed the new client side javascript will still work (and work better since its in parallel)

Why It's Good For The Game

Makes download times less than 5 minutes.

Did you test it?

Yes, but looking at my previous mistake, it'd be better to test-merge it first.

Changelog

🆑
rscadd: Nanoui templates are now downloaded faster. This time it works, honest!
/:cl:

@EgorDinamit EgorDinamit added 🔬1 Code improvement Code is now easier to copy paste. 💿3 Test Merge Candidate Should be test merged to test its functionality. 🚢2 Ported This was fully or partially ported from another codebase. We thank the original authors! ❌0 Broken Hard Do Not Merge, this is failing major checks. and removed 💿3 Test Merge Candidate Should be test merged to test its functionality. labels Nov 13, 2021
@EgorDinamit EgorDinamit added 💣0 Do Not Merge Do not merge, until the head coder approves it. and removed ❌0 Broken Hard Do Not Merge, this is failing major checks. labels Nov 14, 2021
@EgorDinamit EgorDinamit added 💣0 Do Not Merge Do not merge, until the head coder approves it. and removed 💣0 Do Not Merge Do not merge, until the head coder approves it. labels May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
💣0 Do Not Merge Do not merge, until the head coder approves it. 🔬1 Code improvement Code is now easier to copy paste. 🚢2 Ported This was fully or partially ported from another codebase. We thank the original authors!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@EgorDinamit