Makes the crew manifest into TGUI + Sorts the late-join menu #2662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: celotajstg <[email protected]>
* Resolve open position issues in crew manifest * Use the classes helper for multiple classes Co-authored-by: celotajstg <[email protected]>
Gboster-0
added
Code improvement
Kitsunemitsu
previously requested changes
Jan 2, 2025
Kitsunemitsu
reviewed
Jan 2, 2025
|
Will read this tonight or tmrw |
Kitsunemitsu
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Ports the following from TG:
Beeg PR, huge sanity hit.
This PR turns the manifest into TGUI, alongside sorting job stuff into better sections like dis:
Why It's Good For The Game
It looks much better and more informative
Changelog
🆑 Gboster, Celotajs, ghost
Gboster: tweak: the late-join menu should now have better seperation
Celotajs: refactor: The crew manifest has now been converted to TGUI for lobby, ghost, AI and pAI players.
Celotais: fix: Prevented departments from having negative or undefined open positions in the crew manifest
/:cl: