Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How i lost my sanity painfully changing 159 files one by one -- Reworks observation code to be better for any amount of answers #2637

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Gboster-0
Copy link
Collaborator

About The Pull Request

Please end my suffering

  • Makes it so you can assign any amount of wrong or right answers to observations
  • Makes every observation answer capable of having custom text, without extra proc overrides
  • Makes buttons be randomly shuffled every time someone does an observation
  • Fixed misspellings on the correct_answer list making abnormalities unable to be observed by removing it
  • Fixed FAN observation
  • Closes Actually fixes FAN's observation #2636 , this fixes the same issue with the new framework

Why It's Good For The Game

Makes it so you can assign any amount of wrong or right answers to observations

  • Ayup, we now have a framework for that, FAN enjoyers rejoice

Makes every observation answer capable of having custom text, without extra proc overrides

  • Yeah, thats now a thing

Makes buttons be randomly shuffled every time someone does an observation

  • This is a lil controversial of a change imo, but its for the better. Now all the correct answers are at the top of the list so we can organize a lil bit more neatly. Shouldnt have much of an effect on gameplay tho

Fixed misspellings on the correct_answer list making abnormalities unable to be observed by removing it

  • Now the format is "Choice" = list(TRUE or FALSE [depending on if the answer is correct], "Response") making it MUCH harder to make observations unachieveable since we now have to mis-spell "true" for "false" or vice-versa instead of a single letter

Fixed FAN observation

  • before we used the in keyword to search for the correct answer, i think that caused jank with abnos that have a lot of buttons (only FAN). This made it so we directly just yoink the value if its the correct answer or not instead of relying on in

Changelog

🆑
tweak: Observations now have randomly shuffled buttons
fix: FAN's observation now works
/:cl:

@Gboster-0 Gboster-0 added Code improvement Code is now easier to copy paste. Do Not Merge Do not merge, untill a headcoder approves it. Fix There was a bug, and we fixed it! Expansion Expands upon a feature labels Dec 26, 2024
@Kitsunemitsu
Copy link
Contributor

I don't want to give this a review, I'm tossing this shit onto an intern @Blimwe0

@Gboster-0
Copy link
Collaborator Author

I don't want to give this a review, I'm tossing this shit onto an intern @Blimwe0

I think this might be the most cruel thing you have ever done

@Kitsunemitsu
Copy link
Contributor

It's just copy pasta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code improvement Code is now easier to copy paste. Do Not Merge Do not merge, untill a headcoder approves it. Expansion Expands upon a feature Fix There was a bug, and we fixed it!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants