-
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patreon Doublevote #2625
base: master
Are you sure you want to change the base?
Patreon Doublevote #2625
Conversation
Currently bugged, and can only be tested on the live server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-1
Patreon ranks are currently stored as plaintext since we never directly use Patreons API.
Use has_access(<RANK_DEFINE>)
to check. Could probably turn this into overloaded comparison operators on the patreon datum, ping me if that's what you'd like too.
EDIT:
See /code/__DEFINES/~lobotomy_defines/_patreon.dm for defines
See code/datums/patreon_data.dm L62+ for proc
Co-authored-by: Cupa <[email protected]>
Co-authored-by: Cupa <[email protected]>
code/controllers/subsystem/vote.dm
Outdated
@@ -176,10 +176,14 @@ SUBSYSTEM_DEF(vote) | |||
return FALSE | |||
// If user has already voted, remove their specific vote | |||
if(usr.ckey in voted) | |||
if(usr.client.patreon.has_access(SENIOR_AGENT_RANK)) //Patreons get double mapvote |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment is a half-truth. This seems to apply to any vote, be that Restart, Custom, Transfer, Map or Gamemode (yeah I know).
Is this intended behavior?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes; It is. the comment is from an old version of it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah should work now I think! :)
Co-authored-by: Cupa <[email protected]>
Co-authored-by: Cupa <[email protected]>
This has been testmerged for a bit. Any issues during that? |
Nope! I just checked it on the live server and it worked. |
New bug found |
Untestmerged due to merge conflict. |
About The Pull Request
Patreon members get doublevote weight.
Why It's Good For The Game
They assist in our server operations, I want to try giving them something nice
Changelog
🆑
tweak: Patreons get double vote weight
/:cl: