Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patreon Doublevote #2625

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

Kitsunemitsu
Copy link
Contributor

About The Pull Request

Patreon members get doublevote weight.

Why It's Good For The Game

They assist in our server operations, I want to try giving them something nice

Changelog

🆑
tweak: Patreons get double vote weight
/:cl:

@Kitsunemitsu Kitsunemitsu added the Tweak A small change/addition to already existing systems. label Dec 19, 2024
@Kitsunemitsu
Copy link
Contributor Author

Currently bugged, and can only be tested on the live server.

Copy link
Contributor

@Cupax3 Cupax3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1
Patreon ranks are currently stored as plaintext since we never directly use Patreons API.
Use has_access(<RANK_DEFINE>) to check. Could probably turn this into overloaded comparison operators on the patreon datum, ping me if that's what you'd like too.

EDIT:
See /code/__DEFINES/~lobotomy_defines/_patreon.dm for defines
See code/datums/patreon_data.dm L62+ for proc

code/controllers/subsystem/vote.dm Outdated Show resolved Hide resolved
code/controllers/subsystem/vote.dm Outdated Show resolved Hide resolved
@@ -176,10 +176,14 @@ SUBSYSTEM_DEF(vote)
return FALSE
// If user has already voted, remove their specific vote
if(usr.ckey in voted)
if(usr.client.patreon.has_access(SENIOR_AGENT_RANK)) //Patreons get double mapvote
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is a half-truth. This seems to apply to any vote, be that Restart, Custom, Transfer, Map or Gamemode (yeah I know).

Is this intended behavior?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes; It is. the comment is from an old version of it.

Copy link
Contributor

@Cupax3 Cupax3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah should work now I think! :)

code/controllers/subsystem/vote.dm Outdated Show resolved Hide resolved
code/controllers/subsystem/vote.dm Outdated Show resolved Hide resolved
@Cupax3
Copy link
Contributor

Cupax3 commented Dec 27, 2024

This has been testmerged for a bit. Any issues during that?

@Kitsunemitsu
Copy link
Contributor Author

Nope! I just checked it on the live server and it worked.

@Kitsunemitsu
Copy link
Contributor Author

New bug found
Changing your vote turns you back to 1 vote, with leaving one where your first vote is

@Cupax3
Copy link
Contributor

Cupax3 commented Dec 31, 2024

Untestmerged due to merge conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tweak A small change/addition to already existing systems.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants