Adds the mining breach type #2615
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gboster-0
reviewed
Dec 17, 2024
vampirebat74
force-pushed
the
breach_mining
branch
3 times, most recently
from
feda92b to
8ce18a3
Compare
HE level he, teth, waw linters, some zayins rose sign stuff summoners + singing machine fairy festival changes
vampirebat74
force-pushed
the
breach_mining
branch
from
8ce18a3 to
3e941b9
Compare
Gboster-0
reviewed
Jan 1, 2025
code/modules/mob/living/simple_animal/abnormality/aleph/last_shot.dm
Outdated
Show resolved
Hide resolved
Gboster-0
reviewed
Jan 1, 2025
code/modules/mob/living/simple_animal/abnormality/he/laetitia.dm
Outdated
Show resolved
Hide resolved
Gboster-0
reviewed
Jan 1, 2025
|
|
||
| /mob/living/simple_animal/hostile/abnormality/laetitia/proc/SummonAdds()//Mining breach summon | ||
| summon_cooldown = world.time + summon_cooldown_time | ||
| if(LAZYLEN(summon_list) > 9)//this list is not subtracted when minions are killed. Limited to 10 per breach |
There was a problem hiding this comment.
"this list is not subtracted when minions are killed. Limited to 10 per breach" Whats the point of having a list then???
Replace this with a number, this is not only wastefull and can confuse coders but also makes the mobs hard-delete themselfes due to them having a reference being kept
Co-authored-by: Gboster-0 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
What it says on the tin. This breach type is primarily used in the Enkephalin Rush gamemode, though it is also used by monoliths that may appear elsewhere in the future. The main appeal of this breach type is that it prevents most forms of teleportation on the initial breach, as well as addressing gameplay issues related to mining threats.
A few abnormalities are "disabled" through this by deleting themselves immediately. This mainly applies to superbosses such as whitenight and distortedform, whos cores will be used to present an optional fight instead. (TODO: reduce the monetary value of these abnormality cores to zero)
In addition, the scope of this PR includes new breaches entirely, which are planned for meat lantern and rose sign. Their current mechanics impose unreasonable challenges due to the nature of the gamemode this PR affects.
A handful of abnormalities whom lack regular breaches have also been given abilities for this specific breach type. Those who are inanimate objects like A Poor Screenwriter's Note and Book Without Pictures or Dialogue are now unable to move or attack adjacent targets. Additionally, many abnormalities who use this feature to summon one or more hostile units have been given damage coefficients and increased HP.
Singing Machine will now perform its music until suppressed, boasting high HP and decent defenses.
Three "summoner" archetypes have been created.
Type 1:
Immobile, tanky unit that summons many units over time, until suppressed.
YMBS, Book, Rose Sign
Type 2:
Controls a subordinate entity
La Luna, Screenwriter
Type 3:
Capable of combat and movement, slower summons and lesser quantities permitted.
Laetitia, Fairy Festival, Contract
Bloodbath now has a unique hostile breach recycling assets from its Distorted Form variant.
ZAYIN abnormalities will utilize this breach type for an easier version of their respective pink midnight breaches, excluding Fairy Festival who has a unique breach.
Why It's Good For The Game
LC13 has normally imposed many restrictions on how abnormalities should behave for the main gameplay loop. I wish for my gamemode to eventually include every abnormality in the game, each imposing a challenge to the player. I hope that these new features will be used for more creative projects in the future.
Changelog
🆑
add: breach_mining to abnormalities defines
fix: rose sign's roses now remove statuses when qdeleted
imageadd: fairy festival breach
soundadd: fairy queen sfx, one sin attack
code: new breach types, monolith changes
/:cl: