Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

J Corp Representative #2141

Merged
merged 21 commits into from
Jul 30, 2024
Merged

J Corp Representative #2141

merged 21 commits into from
Jul 30, 2024

Conversation

tile4
Copy link
Collaborator

@tile4 tile4 commented May 15, 2024

About The Pull Request

Adds a J corp Representative to the possible representatives you can get. The main gimmicks this rep has is around locking out some of the bad outcomes of RNG, such as increasing the chance to get better loot from gacha, as well as improve chances to get better gear from the well.

Why It's Good For The Game

More Representatives is nice to have.

Changelog

🆑
add: Added new things
/:cl:

@Gboster-0 Gboster-0 added the Expansion Expands upon a feature label May 16, 2024
@Kitsunemitsu
Copy link
Contributor

Wait for Crits; this could be epic. Crit build time.

@Kitsunemitsu
Copy link
Contributor

This PR will wait a little longer, as I have some ideas to flesh out J-Corp but it needs more PRs merged first.

@InsightfulParasite
Copy link
Collaborator

InsightfulParasite commented Jun 20, 2024

Assigned @Kitsunemitsu since she has a plan for this one and it will make sure it doesnt get lost to the annuls of history.

@InsightfulParasite InsightfulParasite added this to the July Testmerges milestone Jul 7, 2024
Copy link
Contributor

@Kitsunemitsu Kitsunemitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While a little barebones, is a great addition to the game.
One small change to make and the rest looks fine to me.

ModularTegustation/tegu_items/refinery/crates/_crate.dm Outdated Show resolved Hide resolved
@tile4 tile4 requested a review from Kitsunemitsu July 28, 2024 19:45
Copy link
Contributor

@Kitsunemitsu Kitsunemitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me.
Quite barebones, but what can you do.

@Kitsunemitsu Kitsunemitsu merged commit b214619 into vlggms:master Jul 30, 2024
8 checks passed
@tile4 tile4 deleted the J-Corp-Rep branch November 5, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Expansion Expands upon a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants