Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisiting snow_whites_apple #1486

Conversation

InsightfulParasite
Copy link
Collaborator

@InsightfulParasite InsightfulParasite commented Oct 1, 2023

About The Pull Request

Due to my new experience with coding i felt like i should go back and refine the code in my old abnormalities.
Gave her a new ability to make barriers to block bullets if shes shot.
New player snow white spell.
Vines no longer do stamina damage but take 2 attempts to pass by normal means.
Changed vine_list from a global list to a static list on snow white's apple.
Tweaks death effect to apply more to torsos than entire bodies.
Removed vine check from snow whites apples ego weapon and adds a more descriptive text explaining its ability.

This was some code i saw in effects. If anything breaks it might be because of this:
'f0442_victem': changed in left
'curiosity': changed same in both
'long-nosed': changed same in both
'lobotomizer': added in left

Testing didnt show any runtime errors.

Why It's Good For The Game

Refined code and fixes some issues that were complained about such as stamina damage focus.

Changelog

🆑
tweak: Snow Whites Apple
tweak: Stem
/:cl:

@InsightfulParasite InsightfulParasite added the Tweak A small change/addition to already existing systems. label Oct 1, 2023
@InsightfulParasite InsightfulParasite self-assigned this Oct 1, 2023
@InsightfulParasite InsightfulParasite changed the title revisiting snow_whites_apple Revisiting snow_whites_apple Oct 1, 2023
@InsightfulParasite InsightfulParasite force-pushed the revisiting-snow-whites-apple branch 16 times, most recently from f80bd8b to 4be6c11 Compare October 2, 2023 22:19
@InsightfulParasite InsightfulParasite marked this pull request as ready for review October 2, 2023 22:24
@LanceSmites328 LanceSmites328 added the Test Merge Candidate Should be test merged to test its functionality. label Oct 4, 2023
@InsightfulParasite InsightfulParasite force-pushed the revisiting-snow-whites-apple branch 9 times, most recently from 6fdb4d8 to c482f4d Compare October 11, 2023 06:58
@InsightfulParasite InsightfulParasite force-pushed the revisiting-snow-whites-apple branch 7 times, most recently from b008656 to d7afa00 Compare October 20, 2023 05:16
@InsightfulParasite InsightfulParasite force-pushed the revisiting-snow-whites-apple branch 2 times, most recently from f9c1b7e to 0fb99ec Compare October 24, 2023 04:50
@InsightfulParasite InsightfulParasite force-pushed the revisiting-snow-whites-apple branch 3 times, most recently from bd1aba9 to 5b75c0a Compare November 3, 2023 00:54
@InsightfulParasite InsightfulParasite force-pushed the revisiting-snow-whites-apple branch 3 times, most recently from 80fe1ca to 7bd0941 Compare November 13, 2023 22:50
@InsightfulParasite InsightfulParasite force-pushed the revisiting-snow-whites-apple branch 2 times, most recently from 2183f03 to bfe662b Compare November 29, 2023 02:16
@InsightfulParasite InsightfulParasite force-pushed the revisiting-snow-whites-apple branch 4 times, most recently from ec28362 to 9daa5c6 Compare December 4, 2023 21:39
@InsightfulParasite InsightfulParasite force-pushed the revisiting-snow-whites-apple branch from 930240f to dfe0044 Compare December 6, 2023 21:20
Spell implementation

Update actions_abnormality.dmi

Update code/modules/mob/living/simple_animal/abnormality/waw/snow_whites_apple.dm

Update code/modules/mob/living/simple_animal/abnormality/waw/snow_whites_apple.dm

Co-Authored-By: [̸R̵e̵d̴a̴c̶t̸e̸d̴]̵ <[email protected]>
@InsightfulParasite InsightfulParasite force-pushed the revisiting-snow-whites-apple branch from dfe0044 to c222bc2 Compare December 6, 2023 21:20
@LanceSmites328 LanceSmites328 removed the Test Merge Candidate Should be test merged to test its functionality. label Dec 7, 2023
@LanceSmites328 LanceSmites328 merged commit fb0fa65 into vlggms:master Dec 7, 2023
7 of 8 checks passed
@InsightfulParasite InsightfulParasite deleted the revisiting-snow-whites-apple branch December 8, 2023 06:06
vampirebat74 pushed a commit to vampirebat74/lobotomy-corp13 that referenced this pull request May 10, 2024
Update snow_whites_apple.dm

Spell implementation

Update actions_abnormality.dmi

Update code/modules/mob/living/simple_animal/abnormality/waw/snow_whites_apple.dm

Update code/modules/mob/living/simple_animal/abnormality/waw/snow_whites_apple.dm

Co-authored-by: [̸R̵e̵d̴a̴c̶t̸e̸d̴]̵ <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tweak A small change/addition to already existing systems.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants