vvet: fix for dir running + new features (track long fns, empty fns and repeated code) #23405
Conversation
|
Please add tests too in You can modify ( |
Thanks. I just add it. |
| const indexexpr_cutoff = 10 | ||
| const infixexpr_cutoff = 10 | ||
| const selectorexpr_cutoff = 10 | ||
| const callexpr_cutoff = 10 | ||
| const stringinterliteral_cutoff = 10 | ||
| const stringliteral_cutoff = 10 | ||
| const ascast_cutoff = 10 | ||
| const stringconcat_cutoff = 10 | ||
|
|
||
| // minimum size for string literals | ||
| const stringliteral_min_size = 20 | ||
|
|
||
| // long functions cutoff | ||
| const long_fns_cutoff = 300 |
There was a problem hiding this comment.
These should be customizable.
An easy way for that is with something like:
const indexexpr_cutoff = os.getenv_opt('VVET_INDEXEXPR', '10').int()
The negative is that setting env variables on windows in cmd for one off commands is clumsier.
| struct VetAnalyze { | ||
| mut: | ||
| repeated_expr_cutoff shared map[string]int // repeated code cutoff | ||
| repeated_expr shared map[string]map[string]map[string][]token.Pos // repeated exprs in fn scope |
There was a problem hiding this comment.
Why is it shared?
Afaik v vet is not parallel?
This PR fixes:
This PR implements:
Huly®: V_0.6-21836