basenc implementation #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Couldn't hurt to open a PR to add them to stdlib. They can be discussed there. Personally, I've never needed any of them, but someone does or they wouldn't exist. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The --z85 encoding is one I had not heard of before. Fixes several issues with base64 interop implementations according to the RFC.
The base16, base32hex, binary (lsbf & msbf) and z85 implementations are not present in the V's standard library. Should they? The ones in this program are straightforward and could be added. I'm willing to do the work.
Talk it over with the team if you're interested and let me know.