Simplify tests using platform-specific test functionality #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JalonSolov
approved these changes
Feb 16, 2024
syrmel
added a commit
to syrmel/v-coreutils
that referenced
this pull request
Feb 17, 2024
Add help to common CoreutilInfo Add help format_output WIP Add shared pwd functions Finally progress on the parser Working mount point resolution Standardize common return codes Implement more stat Implementing --file-system for stat Updating help Add --printf to stat Cleaning up stat Add tty util (vlang#138) * Workflow test * Workflow test for download * Update name * Use bin path * Try with seq * Download with powershell * Fix path * Test with two utils * Initial tty * Add tty to Windows exceptions * Update README * Remove workflow experiments * Cleaner handling of unsupported platforms * Match no tty error to GNU coreutil * Mark Windows as unsupported for tty * Match error even more precisely to GNU tty * Prevent tests in supported platforms Add users util (vlang#139) * Put eol() in common * Add assert_same_exit_code() to TestRig * Initial users util * Return in sorted order * Move pointer indexing into unsafe block * Fix test for Windows * Add more detail for some errors to TestRig * v fmt * Nicer small diff reporting in same_results * Correct call to eprintln_small_diff * No eol if empty result returned * Fix quotes in extra operand error Simplify tests using platform-specific test functionality (vlang#140) * Simplify tests using platform-specific test filtering * Platform-specific tests for tty * Remove is_supported_platform from TestRig, more elegantly solved with platform tests * Use the uptime_nix_test in CI Flaky tests
JalonSolov
pushed a commit
that referenced
this pull request
Feb 17, 2024
* Initial stat Add help to common CoreutilInfo Add help format_output WIP Add shared pwd functions Finally progress on the parser Working mount point resolution Standardize common return codes Implement more stat Implementing --file-system for stat Updating help Add --printf to stat Cleaning up stat Add tty util (#138) * Workflow test * Workflow test for download * Update name * Use bin path * Try with seq * Download with powershell * Fix path * Test with two utils * Initial tty * Add tty to Windows exceptions * Update README * Remove workflow experiments * Cleaner handling of unsupported platforms * Match no tty error to GNU coreutil * Mark Windows as unsupported for tty * Match error even more precisely to GNU tty * Prevent tests in supported platforms Add users util (#139) * Put eol() in common * Add assert_same_exit_code() to TestRig * Initial users util * Return in sorted order * Move pointer indexing into unsafe block * Fix test for Windows * Add more detail for some errors to TestRig * v fmt * Nicer small diff reporting in same_results * Correct call to eprintln_small_diff * No eol if empty result returned * Fix quotes in extra operand error Simplify tests using platform-specific test functionality (#140) * Simplify tests using platform-specific test filtering * Platform-specific tests for tty * Remove is_supported_platform from TestRig, more elegantly solved with platform tests * Use the uptime_nix_test in CI Flaky tests * Add exit codes and help to common * Put common pwd functionality in common * Initial stat * Review fs type tests later * Explicit variable to pass ref * Better test coverage for stat and document GNU 9.x deviations * Update README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
is_supported_platformlogic from TestRig and manyif is_supported_platformchecks since tests can now be provided only for platforms for which they make sense.