cleanups and compatibility with indigo-player #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 3, 2020 13:39
* the presence of the 'sips' executable is now autodetected to let it work out of the box on non-mac machines * TIMESYNC_ADJUST isn't neccessary on more recent ffmpeg executables. if not set to -1 the time stamps will not start with 0:00.000, which is not accepted by some applicationes (see: matvp91/indigo-player#56) * explicit cue identifierers in the output don't make much sense and also tend to be incompatible. (e.g. in case of indigo-player)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this merge requests includes some minor code cleanups and fixes to archive compatibility with indigo-player
fixes: matvp91/indigo-player#56