fix: error in react/storybook #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the following problems: - "TypeError: Cannot read properties of undefined" occurred in Renderer.stories.js - docs.autodocs setting that was added by `npx storybook@latest upgrade` in PR #1419 is not needed and commented out. - "build-dev" in packages/core did not generate type definitions and build-dev failed in packages/react. - microbundle-crl is old and not maintained, so it should be replaced with microbundle.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following problems:
npx storybook@latest upgradein PR Update deps and related fixes: lerna v8, prettier v3, react-scripts v5, storybook v8 #1419 is not needed and commented out.