Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Arabic words look separated when broken at soft hyphen #1415

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Fix Arabic words look separated when broken at soft hyphen #1415

merged 3 commits into from
Nov 8, 2024

Commits on Nov 6, 2024

  1. Fix Arabic words look separated when broken at soft hyphen. 

    This change fixes the issue I described in vivliostyle#1414
It works, but I'm not sure whether it's clean code 😅 sorry.
    @MoamenAbdelsattar
    MoamenAbdelsattar authored Nov 6, 2024
    Configuration menu
    Copy the full SHA
    f802e59 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. fix: Make Arabic letters look connected before and after break at sof… 

    …t hyphen

- fix vivliostyle#1414
    @MurakamiShinyu
    MurakamiShinyu authored Nov 8, 2024
    Configuration menu
    Copy the full SHA
    03bc5ea View commit details
    Browse the repository at this point in the history

  2. prevent ESLint error no-misleading-character-class 

    Disable ESLint "no-misleading-character-class" check:
https://eslint.org/docs/latest/rules/no-misleading-character-class
    @MurakamiShinyu
    MurakamiShinyu authored Nov 8, 2024
    Configuration menu
    Copy the full SHA
    907bc57 View commit details
    Browse the repository at this point in the history