fix: Improve epub:noteref/footnote support #1400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vivliostyle.js supports EPUB footnotes with `epub:type="noteref"` and `epub:type="footnote"` attributes. However, there were the following issues: - `epub:type="noteref"` did not work when the `href` attribute contains a file name, e.g., `<a href="sample.xhtml#fn1" epub:type="noteref">`, even if the file name is the same as the current document. - It only worked with XHTML documents.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
MurakamiShinyu
added a commit
that referenced
this pull request
Oct 25, 2024
fix: Improve epub:noteref/footnote support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vivliostyle.js supports EPUB footnotes with
epub:type="noteref"andepub:type="footnote"attributes. However, there were the following issues:epub:type="noteref"did not work when thehrefattribute contains a file name, e.g.,<a href="sample.xhtml#fn1" epub:type="noteref">, even if the file name is the same as the current document.