Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(viewer): selection highlighting problems on iOS #1223

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

MurakamiShinyu
Copy link
Member

This fixes the followintg problems that only occur on iOS (iPhone and iPad).

This fixes the followintg problems that only occur on iOS (iPhone and iPad).

- marker highlighting position is wrongly shifted.
- highlighting of found text is not shown.
  This is due to the [WebKit Bug 199211 - Selection highlight not shown on programmatic focus after initial load](https://bugs.webkit.org/show_bug.cgi?id=199211)
- Find Next/Previous button clears the previous found position and cannot continue same text searching
@vercel
Copy link

vercel bot commented Sep 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
vivliostyle ✅ Ready (Inspect) Visit Preview Sep 18, 2023 5:55am

@MurakamiShinyu MurakamiShinyu merged commit 439fc42 into master Sep 18, 2023
3 checks passed
@MurakamiShinyu MurakamiShinyu deleted the fix/tweak-viewer-ui-for-iOS branch September 18, 2023 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant