Merge pull request #1220 from vivliostyle/fix/issue1219

fix(viewer): Navigation with page slider should not affect browser history stack
vivliostyle · Aug 31, 2023 · f1147ea · f1147ea · vercel · Aug 31, 2023
2 parents a7b1ed7 + 7b3f117
commit f1147ea
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/viewer/src/viewmodels/navigation.ts b/packages/viewer/src/viewmodels/navigation.ts
@@ -353,7 +353,7 @@ class Navigation {
         if (this.viewerOptions.renderAllPages()) {
           const pageNumber = Number(pageNumberText);
           const epageNav = this.viewer.epageFromPageNumber(pageNumber);
-          this.viewer.navigateToEPage(epageNav);
+          this.viewer.navigateToEPage(epageNav, false);
         } else {
           const pageNumberElem = document.getElementById(
             "vivliostyle-page-number",
@@ -553,7 +553,7 @@ class Navigation {
     ) as HTMLInputElement;
     const pageNumber = Number(pageNumberElem.value);
     const epageNav = this.viewer.epageFromPageNumber(pageNumber);
-    this.viewer.navigateToEPage(epageNav);
+    this.viewer.navigateToEPage(epageNav, false);
 
     return true;
   };

diff --git a/packages/viewer/src/viewmodels/viewer.ts b/packages/viewer/src/viewmodels/viewer.ts
@@ -287,8 +287,8 @@ class Viewer {
     this.coreViewer.navigateToPage(Navigation.LAST);
   }
 
-  navigateToEPage(epage: number): void {
-    if (Math.abs(epage - this.epage()) > 1) {
+  navigateToEPage(epage: number, pushHistory?: boolean): void {
+    if (pushHistory === undefined || pushHistory) {
       window.history.pushState(null, null);
     }
     this.coreViewer.navigateToPage(Navigation.EPAGE, epage);