Make project starting when site is removed via create-app #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnyomair
reviewed
Nov 28, 2024
I think it's easier just not to touch too much in Admin and API. If you remove the site you could also remove some modules in the API und some Providers in Admin and and and. So my answer is that it is not really possible. |
|
maybe we should get rid of this remove-site instead of doing it "half". |
My pleasure! |
|
Feedback from the ones who actually use this script: better a half way solution than nothing. So I'll reopen this and we should either merge this PR or #577 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the application does not start anymore when create-app remove-site has been executed due to the deep incorporation of SiteConfigs. This PR injects a lightweight type to comply the needs and is to be meant deleted anyway. This way the application will start with a functioning scope.