Improve rendering of site #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasdax98
reviewed
Sep 3, 2024
thomasdax98
previously approved these changes
Sep 5, 2024
nsams
reviewed
Sep 5, 2024
thomasdax98
reviewed
Sep 5, 2024
as the preview forces the rendering to by dynamic
nsams
approved these changes
Sep 5, 2024
thomasdax98
approved these changes
Sep 5, 2024
johnnyomair
reviewed
Sep 9, 2024
Comment on lines
+12
to
+46
| const PagePreview: React.FunctionComponent = () => { | ||
| const iFrameBridge = useIFrameBridge(); | ||
|
|
||
| const { fetch, graphQLFetch } = useBlockPreviewFetch(graphQLApiUrl); | ||
|
|
||
| const [blockData, setBlockData] = useState<PageContentBlockData>(); | ||
| useEffect(() => { | ||
| async function load() { | ||
| if (!iFrameBridge.block) { | ||
| setBlockData(undefined); | ||
| return; | ||
| } | ||
| const newData = await recursivelyLoadBlockData({ | ||
| blockType: "PageContent", | ||
| blockData: iFrameBridge.block, | ||
| graphQLFetch, | ||
| fetch, | ||
| }); | ||
| setBlockData(newData); | ||
| } | ||
| load(); | ||
| }, [iFrameBridge.block, fetch, graphQLFetch]); | ||
|
|
||
| return <div>{blockData && <PageContentBlock data={blockData} />}</div>; | ||
| }; | ||
|
|
||
| const StagePreview = () => { | ||
| const { block: stage } = useIFrameBridge(); | ||
| return stage ? <StageBlock data={stage} /> : null; | ||
| }; | ||
|
|
||
| const previewComponents = { | ||
| page: PagePreview, | ||
| stage: StagePreview, | ||
| }; |
There was a problem hiding this comment.
Should we move this preview components into separate files? Otherwise this file may get rather large when having many different previews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
next-runtime-envas it prevents static rendering (use context inlayout.tsxinstead)config.tslayout.tsxfiles for block preview and siteSupersedes #350 and #349
To discuss:
SiteConfigsProvider.tsxandSiteConfigProvider.tsxto @comet/cms-site?Ways to access the current SiteConfig
Use
await getSiteConfigForDomain(params.domain)Not possible, instead pass the necessary data from the page
Use the
useSiteConfig()-hook