chore: fixed rule where skip didn't work (#56)

vitest-dev · Feb 19, 2023 · 97a62c7 · 97a62c7
1 parent 838f7ca
commit 97a62c7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/src/rules/no-skipped-tests.test.ts b/src/rules/no-skipped-tests.test.ts
@@ -2,9 +2,10 @@ import { RuleTester } from '@typescript-eslint/utils/dist/ts-eslint'
 import { it } from 'vitest'
 import rule, { RULE_NAME } from './no-skipped-tests'
 
-const valids = ['it("test", () => {});']
+const valids = ['it("test", () => {});', 'test("test", () => {})']
 
 const invalids = [
+	'test.skip("test", () => {});',
 	'it.skip("test", () => {});',
 	`describe.skip("math", () => {
 		it("works", () => {

diff --git a/src/rules/no-skipped-tests.ts b/src/rules/no-skipped-tests.ts
@@ -25,11 +25,11 @@ export default createEslintRule<Options, MessageIds>({
 					const { callee } = node.expression
 					if (
 						callee.type === 'MemberExpression' &&
-            callee.object.type === 'Identifier' &&
-            (callee.object.name === 'it' ||
-              callee.object.name === 'describe') &&
-            callee.property.type === 'Identifier' &&
-            callee.property.name === 'skip'
+						callee.object.type === 'Identifier' &&
+						(callee.object.name === 'it' ||
+							callee.object.name === 'describe' || callee.object.name === 'test') &&
+						callee.property.type === 'Identifier' &&
+						callee.property.name === 'skip'
 					) {
 						context.report({
 							node,