-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vtorc
: make SQL formatting consistent
#17154
Merged
shlomi-noach
merged 5 commits into
vitessio:main
from
timvaillancourt:vtorc-cleanup-sql
Nov 26, 2024
Merged
vtorc
: make SQL formatting consistent
#17154
shlomi-noach
merged 5 commits into
vitessio:main
from
timvaillancourt:vtorc-cleanup-sql
Nov 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Vaillancourt <[email protected]>
timvaillancourt
added
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Component: VTorc
Vitess Orchestrator integration
labels
Nov 5, 2024
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Nov 5, 2024
timvaillancourt
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Nov 5, 2024
Signed-off-by: Tim Vaillancourt <[email protected]>
timvaillancourt
requested review from
deepthi,
shlomi-noach and
GuptaManan100
as code owners
November 5, 2024 23:05
Signed-off-by: Tim Vaillancourt <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17154 +/- ##
==========================================
+ Coverage 67.39% 67.41% +0.02%
==========================================
Files 1573 1573
Lines 253136 253181 +45
==========================================
+ Hits 170603 170690 +87
+ Misses 82533 82491 -42 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Tim Vaillancourt <[email protected]>
timvaillancourt
added
Type: Internal Cleanup
and removed
NeedsIssue
A linked issue is missing for this Pull Request
labels
Nov 6, 2024
shlomi-noach
approved these changes
Nov 14, 2024
GuptaManan100
approved these changes
Nov 26, 2024
Signed-off-by: Manan Gupta <[email protected]>
5 tasks
jwangace
pushed a commit
to jwangace/vitess
that referenced
this pull request
Nov 27, 2024
Signed-off-by: Tim Vaillancourt <[email protected]> Signed-off-by: Manan Gupta <[email protected]> Co-authored-by: Manan Gupta <[email protected]> Signed-off-by: Jun Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: VTorc
Vitess Orchestrator integration
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Type: Internal Cleanup
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the consistency of SQL statements in
go/vt/vtorc
(as discussed with @dbussink offline)Some notes:
SELECT
,AS
,OR
,DATETIME
,SECOND
/HOUR
/DAY
, etc\t
for indentation - in places it's a mix of spaces and tabssomething = ?
Related Issue(s)
#17164
Checklist
Deployment Notes