fix(lib)!: remove format prefixes for cjs and esm #8107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shinigami92
reviewed
May 12, 2022
| @@ -592,6 +592,10 @@ export function resolveLibFilename( | |||
| extension = format === 'es' ? 'mjs' : 'js' | |||
| } | |||
|
|
|||
| if (format === 'cjs' || format === 'es') { | |||
There was a problem hiding this comment.
Not for this PR, but should we allow es(deprecate this) / esm (new value)
There was a problem hiding this comment.
Do you have some links to support esm over es? Rollup is using es for their format config, I think alignment with them is good here.
There was a problem hiding this comment.
Oh interesting, I thought this was coming from cjs/esm wordings that also e.g. TypeScript is using
Shinigami92
approved these changes
May 12, 2022
patak-dev
approved these changes
May 12, 2022
patak-dev
changed the title
patak-dev
added
p2-nice-to-have
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #6827. Remove the format extensions for
cjsandesm. Example:my-lib.es.js->my-lib.js.This is a breaking change.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).