fix: Re-enable minifying es lib #6670
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kurtil
changed the title
|
needs to follow #6555 |
|
Closing in favour of #6585. Minifying es lib today also works partially now, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@yyx990803 said "We should probably default to not minifying in lib mode in Vite" here.
Instead of this requested behaviour, this commit 06d86e4 prevents es libs to be minified even if the
minifyoption is set totrue,esbuildorterser.This PR change the default value of the
minifyoption tofalseif aliboption is present, re-enabling minifying es lib ifminifyis requested.What is the purpose of this pull request?