fix(hmr): reload CSS when inlined SVG is changed #18972
Draft
+132
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
added
feat: hmr
p4-important
sapphi-red
commented
Dec 16, 2024
Comment on lines
+796
to
799
| // TODO | ||
| if ( | ||
| !isCSSRequest(node.url) && | ||
| [...node.importers].every((i) => isCSSRequest(i.url)) |
There was a problem hiding this comment.
With this PR, changing any file referenced by CSS will cause a full reload because of this code (slightly related: this code is the cause of #9512). That'll probably degrade the UX quite a bit.
For this reason, I'm considering to only handle inlined SVGs for now (in a different PR).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #18963
This PR fixes #18963 by registering all referenced assets as a dependency of CSS files.