-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix run css playground with legacy sass #18946
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really sure about expectToBeEither
, it feels like it could make tests harder to debug if it fails 🤔 Should the HMR tests do cleanup instead so it returns to original? Are the tests also running serially too?
The tests ( |
Does adding vite/playground/vitestGlobalSetup.ts Lines 44 to 47 in c28df71
|
Oh, I wasn't aware of that! Let me try that. |
Yep, it works 👍 |
Description
Built on top of #18945Since #18636, the legacy sass tests for playground/css was not run because
playground/css/__tests__/sass-legacy/sass-legacy.spec.ts
was missing. This PR adds that.Also this PR extracts sass related tests in a different file to skip running other tests for
sass-legacy.spec.ts
andsass-modern.spec.ts
.old description
Also this PR does the following changes to reduce flaky fails.
css.spec.ts
css.spec.ts
andsass-modern.spec.ts
andsass-legacy.spec.ts
tries to change the file and fails sometimes.css.spec.ts
changes the file and other tests observes the changed file.sass-*.spec.ts
expectToBeEither
and also to reduce duplicated test runs.