-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make --force
work for all environments
#18901
base: main
Are you sure you want to change the base?
fix: make --force
work for all environments
#18901
Conversation
IIUC we wanted the top-level That means we likely have to alter how vite/packages/vite/src/node/cli.ts Line 185 in 7a0758c
And it's a bit tricky to do so there since we don't know all environments upfront. We might need to inject a plugin with the |
I added a new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also think we should deprecate the force
options 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense 👍 I wonder if the name can be shorten as forceOptimize
though, or maybe it could be more specific like forceOptimizeDeps
.
b418978
Renamed to |
Description
--force
only applied to the client environment. I think passing it should apply to other environments too.Probably the behavior change was caused by #18465