feat(create-vite): minimal One.js option to create-vite react templates #18883
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patak-dev
changed the title
|
TARGET_DIR can be About the Minimal template, we don't do this with other frameworks. If there are other templates available, I think you should let the use choose. We only have the barebone requirement for the templates we maintainer in the create-vite package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed with @patak-dev this should add a minimal template for One for easy testing with Vite and for bugs.
One thing I'm not sure of - we expect TARGET_DIR to be just a name like "app-name", we don't accept a path. I can make the changes in the cli easily though to accept a path, but didn't see clearly if this was expected or not here.