Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(migration): add assets names array hint to avoid breaking the build when manifest enabled #18846

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

docs(migration): add assets names array hint to avoid breaking the build when manifest enabled #18846

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3a42f0
docs(migration): add assets names array hint to avoid breaking the bu…
userquin Nov 30, 2024
4869ee2
chore: it is field not file
userquin Nov 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/guide/migration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,8 @@ If you prefer to stick with `style.css` like in Vite 5, you can set `build.lib.c

There are other breaking changes which only affect few users.

- [[#18240] refactor: use `originalFileNames/names`](https://github.com/vitejs/vite/pull/18240):
- any plugin that emits assets with type `asset` must include the `names` array in the asset to avoid breaking the build when the manifest is enabled. Older versions of Vite use the `name` field to check whether the asset should be included in the manifest.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not just older versions. Vite 6 does too

vite/packages/vite/src/node/plugins/asset.ts

Line 400 in b39e696

name: path.basename(file),

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe only when using generateBundle hook adding the asset to the bundle?

- [[#17922] fix(css)!: remove default import in ssr dev](https://github.com/vitejs/vite/pull/17922)
- Support for default import of CSS files was [deprecated in Vite 4](https://v4.vite.dev/guide/migration.html#importing-css-as-a-string) and removed in Vite 5, but it was still unintentionally supported in SSR dev mode. This support is now removed.
- [[#15637] fix!: default `build.cssMinify` to `'esbuild'` for SSR](https://github.com/vitejs/vite/pull/15637)
Expand Down