fix(config): remove error if require resolve to esm #18437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
added
the
p3-downstream-blocker
sapphi-red
previously approved these changes
Oct 24, 2024
There was a problem hiding this comment.
I guess we can add a friendly error here instead if we need to. But I guess there won't be much users using CJS config now and not worth doing it.
Co-authored-by: 翠 / green <[email protected]>
|
Yeah I think that would involve tracking the specifier to its resolved path, which is tricky to handle and not really worth it now as most of our recommended setups don't use or compile to CJS. |
sapphi-red
approved these changes
Oct 24, 2024
|
The test fails should be fixed by #18446. |
patak-dev
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@joyeecheung mentioned in the e18e server that the friendly error in #13283 was preventing
require(esm)from working. I've removed it in this PR.I intially wanted to check
NODE_OPTIONSor node >=23 instead, but that opens up needing to check for deno and bun too since they support it, so I figured it's easier to simply remove it. However, I'm open to doing the checks still if we prefer.NOTE: This PR does not remove the other error reporting when we couldn't resolve a CJS entrypoint for an ESM package. Some package like
@sveltejs/vite-plugin-svelteexport ESM with the"import"condition only, so node wouldn't be able to resolve it still forrequire(esm).